refactor: update signal example #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Rect's rotation to signal on Circle's scale instead of changing both at the same time. This is visually identical to the existing video.
|
Apologies for not creating an issue first! I figured this might be considered a "trivial" change based on the contribution guide from the main repo. I can't seem to request a review (I might just be missing where I can do this in github). Hopefully pinging will suffice :) @aarthificial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rect's rotation property to change based on Circle's scale signal instead of changing both at the same time. This is visually identical to the existing video/example, but might make the correlation between the scale & rotation more apparent for anyone picking up these examples.